Convert softmax from CTest to GTest #3479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vsevolod1983
requested review from
BrianHarrisonAMD and
BradPepersAMD
as code owners
bghimireamd
reviewed
Jan 28, 2025
| CompareResults(tensorGpuDataBackward, tensorCpuDataBackward); | ||
| } | ||
|
|
||
| std::vector<T> GetForwardCpu() const |
There was a problem hiding this comment.
we also have mloSoftmaxForwardRunHost and mloSoftmaxBackwardRunHost too.
There was a problem hiding this comment.
Since this one is parallel may be we can move this mloSoftmaxForwardRunHost and mloSoftmaxBackwardRunHost to avoid duplications.
There was a problem hiding this comment.
hi, @bghimireamd
In C-test I did not see calls of these functions. Scope of my refactoring was to replace c-test with g-test.
If I misunderstand something, lets discuss.
There was a problem hiding this comment.
Or do you mean that we need to enhance test coverage for softmax? If yes I would prefer to do it in separate PR/ticket.
There was a problem hiding this comment.
yeah separate PR/ticket make more sense here :)
BrianHarrisonAMD
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CTest to GTest conversion for Softmax
soft_max.cpp file is detected as renamed (moved), so probably will not be easy to review.